Cornelicorn/oh-my-zsh
1
0
Fork 0
mirror of https://github.com/robbyrussell/oh-my-zsh.git synced 2026-09-28 05:56:07 +02:00
Code Issues Releases Wiki Activity

fix(init): keep the revision helper's REPLY out of the global scope

Browse Source 
_omz_git_head reports through $REPLY, which stayed set for the rest of
startup and could overwrite caller state or be mistaken for the result
of an unrelated read. Call it inside an anonymous function that declares
REPLY local.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Robby Russell
2026-09-07 07:56:48 -07:00
co-authored by Claude Opus 5
parent a8da200b18
commit c6d78edc8f
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
oh-my-zsh.sh
+7 -3
View File
@@ -152,9 +152,13 @@ _omz_git_head() {
[[ -n "$REPLY" ]] [[ -n "$REPLY" ]]
} }
# Construct zcompdump OMZ metadata # Construct zcompdump OMZ metadata. The helper reports through $REPLY, so
_omz_git_head || REPLY="$(builtin cd -q "$ZSH"; git rev-parse HEAD 2>/dev/null)" # call it in a scope that keeps that out of the global namespace.
zcompdump_revision="#omz revision: $REPLY" () {
local REPLY
_omz_git_head || REPLY="$(builtin cd -q "$ZSH"; git rev-parse HEAD 2>/dev/null)"
typeset -g zcompdump_revision="#omz revision: $REPLY"
}
zcompdump_fpath="#omz fpath: $fpath" zcompdump_fpath="#omz fpath: $fpath"
unset -f _omz_git_head unset -f _omz_git_head