Cornelicorn/oh-my-zsh
1
0
Fork 0
mirror of https://github.com/robbyrussell/oh-my-zsh.git synced 2026-09-28 14:06:12 +02:00
Code Issues Releases Wiki Activity

fix(gh): preserve valid completion cache on failure

Browse Source
This commit is contained in:
Robby Russell
2026-09-10 05:33:39 -07:00
parent eccb32c94c
commit d03d367f82
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/gh/README.md
+3 -6
View File
@@ -15,9 +15,6 @@ This plugin does not add any aliases.
This plugin caches the completion script and is automatically updated when the This plugin caches the completion script and is automatically updated when the
plugin is loaded, which is usually when you start up a new terminal emulator. plugin is loaded, which is usually when you start up a new terminal emulator.
The cache is stored at: The completion script is stored at `$ZSH_CACHE_DIR/completions/_gh`. If an
update fails, the plugin keeps the last successfully generated completion
- `$ZSH/plugins/gh/_gh` completions script script.
- `$ZSH_CACHE_DIR/gh_version` version of GitHub CLI, used to invalidate
the cache.
plugins/gh/gh.plugin.zsh
+8 -2
View File
@@ -13,6 +13,12 @@ fi
zmodload -F zsh/files b:zf_mv zmodload -F zsh/files b:zf_mv
() { () {
local TMPPREFIX="$ZSH_CACHE_DIR/completions/_gh" local completion_file="$ZSH_CACHE_DIR/completions/_gh"
zf_mv -f -- =( gh completion --shell zsh ) "$TMPPREFIX" local completion_tmp="${completion_file}.$$.${RANDOM}"
if gh completion --shell zsh >| "$completion_tmp" && [[ -s "$completion_tmp" ]]; then
zf_mv -f -- "$completion_tmp" "$completion_file"
fi
command rm -f -- "$completion_tmp"
} &| } &|